cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

docs(UI): match capitalization to match PF guide #1260

Closed aali309 closed 1 month ago

aali309 commented 2 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1146

Description of the change:

This update ensures the UI adheres to the PatternFly design guidelines, promoting a consistent and user-friendly experience. https://www.patternfly.org/ux-writing/capitalization/

Motivation for the change:

see https://github.com/cryostatio/cryostat-web/issues/1146

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...
aali309 commented 2 months ago

@andrewazores Please whenever you have time, checkout on this PR and see if the changes make sense so far.

andrewazores commented 1 month ago

image

Should "Select a target" and "Filter by target..." use Target here?

aali309 commented 1 month ago

image

Should "Select a target" and "Filter by target..." use Target here?

Thinking about it, we dint capitalize target on https://github.com/cryostatio/cryostatio.github.io/pull/153. However, for me Target makes more sense here!

andrewazores commented 1 month ago

Rebase please