cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

[Bug] Custom Target creation form allows creation before connection test succeeds #1261

Closed andrewazores closed 1 month ago

andrewazores commented 1 month ago

Current Behavior

The Custom Target creation form has a connection test widget (Duke icon) which the user should use to check the connection details before creating the target definition.

The form allows the user to attempt to create the target definition before ever clicking the connection test widget. Upon clicking the Create button, Cryostat will perform a connection test anyway, where the Create button goes into a loading state but there is no other immediate feedback about what is happening. The user cannot know if there is a connection test ongoing or if there is some other problem with the server or network.

Expected Behavior

The form should lock the Create button until the connection check has been performed and succeeded. If the user changes any details on the form it should reset the state of the connection check and re-lock the Create button. This way it is clear when a connection check is being performed and the progress is more apparent. The server will still attempt another connection test when the Create button is clicked, but this should succeed very quickly since it should follow shortly after the user has already entered correct details and performed a successful test.

Steps To Reproduce

No response

Environment

No response

Anything else?

image

image