cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

fix(custom-targets): lock form Create button until successful test #1262

Closed andrewazores closed 1 month ago

andrewazores commented 1 month ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1261

Description of the change:

Motivation for the change:

When creating a custom target the server will already perform a connection test anyway. However, the UI is more informative and makes more sense if the user is first required to perform a successful connection test before they can create the target definition.

How to manually test:

  1. Check out and build cryostat3 with this PR
  2. ./smoketest.bash -Otr
  3. Try to create some custom target definitions, like cryostat3:9091, localhost:0, sample-app-1:9093, reports:11124, jfr-datasource:11223, cryostat:9091
github-actions[bot] commented 1 month ago

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1262-0ed25c938de2425a66ea3bcecc523f9bb77a087a bash smoketest.bash # then open http://localhost:8080