To recreate commits with GPG signaturegit fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1261
Description of the change:
handles the case where the response body does not have .data.reason fields. This can happen if the server encounters an unexpected error and responds with an HTTP 500, in which case the response format is not a Cryostat API V2 format but a standard Quarkus 500 format.
locks the Custom Target creation form Create button until a successful connection test is performed. If the form is updated (URL or credentials) the button is re-locked.
Motivation for the change:
When creating a custom target the server will already perform a connection test anyway. However, the UI is more informative and makes more sense if the user is first required to perform a successful connection test before they can create the target definition.
How to manually test:
Check out and build cryostat3 with this PR
./smoketest.bash -Otr
Try to create some custom target definitions, like cryostat3:9091, localhost:0, sample-app-1:9093, reports:11124, jfr-datasource:11223, cryostat:9091
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1261
Description of the change:
.data.reason
fields. This can happen if the server encounters an unexpected error and responds with an HTTP 500, in which case the response format is not a Cryostat API V2 format but a standard Quarkus 500 format.Motivation for the change:
When creating a custom target the server will already perform a connection test anyway. However, the UI is more informative and makes more sense if the user is first required to perform a successful connection test before they can create the target definition.
How to manually test:
./smoketest.bash -Otr
cryostat3:9091
,localhost:0
,sample-app-1:9093
,reports:11124
,jfr-datasource:11223
,cryostat:9091