cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

fix(auth): render username in top bar #1264

Closed andrewazores closed 1 month ago

andrewazores commented 1 month ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes https://github.com/cryostatio/cryostat3/issues/489 Related to https://github.com/cryostatio/cryostat3/pull/490

Description of the change:

If the response from the server includes the Gap-Auth header, use that to determine the user's logged in username. If not, fall back to using the POST /api/v2.1/auth response body. If anything is blank or fails then use the empty string, which the UI already renders as the anonymous user icon.

How to manually test:

  1. Check out cryostat3 and build with this PR
  2. ./smoketest.bash -O
  3. Verify that the username user appears on the top bar
  4. Restart smoketest as ./smoketest.bash -Op to disable the auth proxy
  5. Verify that the anonymous user icon appears on the top bar
aali309 commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1264-c77ea3822e750350a4c14cc14ff9dc0d4d49640a bash smoketest.bash # then open http://localhost:8080