Closed aali309 closed 1 month ago
I think the fix for this problem should include changing this behaviour:
ie there are places where getSessionState()
is called to prevent things from updating until the websocket is connected. The line linked above prevents the target list from loading until there is a websocket connection. Instead of changing the session state calculation, which I think already accurately reflects the actual websocket connection state, I think it might be better to search for places that call getSessionState()
and see if it's really necessary to call it and check for a session.
For example here as well:
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1272
Description of the change:
see https://github.com/cryostatio/cryostat-web/issues/1272
Motivation for the change:
https://github.com/cryostatio/cryostat-web/issues/1272#issue-2338382998
How to manually test: