search

cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

[Bug] Label/Annotation filtering for target nodes is broken #1311

Closed tthvo closed 3 months ago

tthvo commented 3 months ago

Current Behavior

The label/annotation filtering for target nodes is broken as it is now showed as below:

image

Expected Behavior

The labels show as key=value.

Steps To Reproduce

  1. bash smoketesh.bash on latest main.
  2. Open https://localhost:8443
  3. Go to Topology View
  4. Select filter by Target Label or Annotation.
  5. Click on the search input to show available options.
  6. The [object Object] is displayed.

Environment

- OS: Fedora 40
- Environment: `docker-compose` with smoketest
- Version: Cryostat 4.0.0-dev

Anything else?

Potentially affected 3.0.0 release.

tthvo commented 3 months ago

Looks like some regressions when labels/annotations change their representations to [{key: "my-key", value: "my-value"}] list.

andrewazores commented 3 months ago

Confirmed that this is present in 3.0.0.

andrewazores commented 3 months ago

I also never realized before, but we render recording labels like template: Profiling, but Topology node labels/annotations like version=1.20. I'll clean that up with the same PR.

andrewazores commented 3 months ago

Actually, I'll split that change out, since we should backport the bug fix only.

tthvo commented 3 months ago

I also never realized before, but we render recording labels like template: Profiling, but Topology node labels/annotations like version=1.20. I'll clean that up with the same PR.

Ah yes, about this tho, the topology is following key=value convention on the OpenShift side. Should we follow that instead of key: value?

andrewazores commented 3 months ago

That's true. I'll adjust the PR.