andrewazores commented 2 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #405 Fixes: #440

Description of the change:

Removes useless instances of Transactional annotation and replaces them with QuarkusTransaction.joiningExisting() invocations where applicable.

Motivation for the change:

Ensures operations actually occur in a transactional context as expected

How to manually test:

Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
Click around UI performing actions and ensure general functionality works as expected. Pay particular attention to Topology view/actions, Archives > All Targets, and Automated Rules, since these exercise things the most.
Create an automated rule like the one below and ensure that it correctly creates a new recording when enabled, that the recording gets archived every 10 seconds, and after there are 3 archived copies that the oldest one gets pruned when a new one is created. Disabling a rule should stop new archives from being saved.

{
  "id": 1,
  "name": "test",
  "description": "",
  "matchExpression": "target.connectUrl.contains('localhost:0')",
  "eventSpecifier": "template=Profiling,type=TARGET",
  "archivalPeriodSeconds": 10,
  "initialDelaySeconds": 0,
  "preservedArchives": 3,
  "maxAgeSeconds": 300,
  "maxSizeBytes": 0,
  "enabled": true
}

tthvo commented 2 months ago

This is a fix for #405 right? I can help with a quick fix for #412.

andrewazores commented 2 months ago

This is a fix for #405 right? I can help with a quick fix for #412.

Yes, I meant to tag both of those issues for this PR. I got started on it and then got sidetracked - please go ahead and add your fix for 412 :-)

andrewazores commented 2 months ago

/build_test