cryostatio / cryostat

Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io
Other
8 stars 8 forks source link

fix(certs): update generate-dev-certs.sh #422

Closed mwangggg closed 2 months ago

mwangggg commented 2 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #421

Description of the change:

andrewazores commented 2 months ago

Just curious - have you been using this script along with developing the Agent HTTPS keystore piece? I'm curious what you do with these generated certs. The script long predates the auth proxy setup, and used to be used back when Cryostat itself was directly exposed to traffic and needed to allow TLS termination, like what 2.4 does. Now that Cryostat is hidden behind the auth proxy, it's the auth proxy that must be configured to use such a cert.

andrewazores commented 2 months ago

Is this still needed or does #426 replace it?

mwangggg commented 2 months ago

426 replaces it :+1: