andrewazores commented 2 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Description of the change:

Simplifies the MessagingServer (WebSocket notifications) implementation to remove the explicit thread synchronization and message ordering.

Motivation for the change:

Using the EventBus is simpler and less error-prone than manually using synchronization features like blocking queues. Error handling is also improved in this PR, so if sending a notification to any connected client fails then this failure will be logged.

How to manually test:

Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
Click around the UI performing actions and ensure notifications are still received

andrewazores commented 2 months ago

/build_test