cryostatio / cryostat

Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io
Other
8 stars 8 forks source link

fix(graphql): avoid ConcurrentModificationException #433

Closed andrewazores closed 2 months ago

andrewazores commented 2 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #432

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...
aali309 commented 2 months ago

I will keep your changes and remove mine on https://github.com/cryostatio/cryostat3/pull/395/commits/e9b4de4a7367dd75ca2c43338297650db3d81cf5

andrewazores commented 2 months ago

I will keep your changes and remove mine on e9b4de4

Your transformToUni approach is quite good too actually, that looks like it also would have worked well. It might actually be worth doing it that way too, once the current threading and transaction issues (#415 #407 etc.) are fixed up and the GraphQL nonblocking execution is re-enabled...

andrewazores commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/4/2024, 1:10:09 AM. View Actions Run.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/8948191333