search

cryostatio / cryostat

Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io
Other
8 stars 8 forks source link

[Bug] Archived recordings tables improperly react to "Recording Saved" notifications #441

Closed andrewazores closed 1 month ago

andrewazores commented 2 months ago

Current Behavior

When a "Recording Saved" notification is emitted, the Archived recordings tables (at least Recordings > Archived and Archives > All Archives) update with a new entry. However, the recording name added to the table is the name of the source active recording, not the new archived recording filename, and the file size field is undefined/NaN.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

image

andrewazores commented 2 months ago

Related to #294, https://github.com/cryostatio/cryostat-web/pull/1227 https://github.com/cryostatio/cryostat-web/pull/1224 https://github.com/cryostatio/cryostat-web/pull/1222 https://github.com/cryostatio/cryostat-web/pull/1221

andrewazores commented 2 months ago

To test:

  1. run smoketest
  2. create the automated rule below
  3. go to Recordings > select the localhost:0 target > go to Archived tab
  4. wait some time for the automated rule to begin creating archived recordings and notifications to appear
{
  "id": 1,
  "name": "test",
  "description": "",
  "matchExpression": "target.connectUrl.contains('localhost:0')",
  "eventSpecifier": "template=Profiling,type=TARGET",
  "archivalPeriodSeconds": 10,
  "initialDelaySeconds": 0,
  "preservedArchives": 3,
  "maxAgeSeconds": 300,
  "maxSizeBytes": 0,
  "enabled": true
}