cryostatio / cryostat

Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io
Other
8 stars 8 forks source link

feat(Custom Targets): restrict Custom Targets domains #444

Closed aali309 closed 1 month ago

aali309 commented 2 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #323

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

mentioned by: @andrewazores https://github.com/cryostatio/cryostat3/issues/323

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...
aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/8/2024, 5:05:22 PM. View Actions Run.

github-actions[bot] commented 2 months ago

CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9008522991

github-actions[bot] commented 2 months ago

CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9008522991

aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/8/2024, 5:57:45 PM. View Actions Run.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9009057840

aali309 commented 2 months ago

@andrewazores please let me know if this matches what you suggested :)

aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/9/2024, 2:17:58 PM. View Actions Run.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9021675054

aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/9/2024, 2:34:49 PM. View Actions Run.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9021889345

aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/9/2024, 2:46:33 PM. View Actions Run.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9022016975

aali309 commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

Workflow started at 5/15/2024, 6:30:54 PM. View Actions Run.

github-actions[bot] commented 2 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 2 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 2 months ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9103521858

aali309 commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Workflow started at 5/21/2024, 1:43:05 PM. View Actions Run.

github-actions[bot] commented 1 month ago

CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9179012039

andrewazores commented 1 month ago

Rebase after https://github.com/cryostatio/cryostat3/pull/449 is merged and that test failure will be fixed.

aali309 commented 1 month ago

Rebase after #449 is merged and that test failure will be fixed.

Thnx @andrewazores This is very helpful. I wasn't sure what was causing the test failures!

aali309 commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Workflow started at 5/21/2024, 2:09:39 PM. View Actions Run.

github-actions[bot] commented 1 month ago

No OpenAPI schema changes detected.

github-actions[bot] commented 1 month ago

No GraphQL schema changes detected.

github-actions[bot] commented 1 month ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9179352253

andrewazores commented 1 month ago

Looking good! I'd like to see a little refactoring to get rid of the static methods next. You can add a method to Producers.java to return a singleton instance of the URIUtil and inject that wherever it's needed, and I think you could even clean it up so that this is the only place where the new uri-range String property is injected, so that the Custom Discovery (or any other caller) only needs to supply the URL/URI to be tested and the range is already inferred from configuration.

aali309 commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Workflow started at 5/27/2024, 1:51:03 PM. View Actions Run.

github-actions[bot] commented 1 month ago

No GraphQL schema changes detected.

github-actions[bot] commented 1 month ago

No OpenAPI schema changes detected.

github-actions[bot] commented 1 month ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9258630230

andrewazores commented 1 month ago

Refactoring suggestions: https://github.com/aali309/cryostat3/pull/21/files

andrewazores commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Workflow started at 5/29/2024, 1:31:02 PM. View Actions Run.

github-actions[bot] commented 1 month ago

No GraphQL schema changes detected.