Closed aali309 closed 3 months ago
/build_test
Workflow started at 5/8/2024, 5:05:22 PM. View Actions Run.
CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9008522991
CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9008522991
/build_test
Workflow started at 5/8/2024, 5:57:45 PM. View Actions Run.
No GraphQL schema changes detected.
No OpenAPI schema changes detected.
CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9009057840
@andrewazores please let me know if this matches what you suggested :)
/build_test
Workflow started at 5/9/2024, 2:17:58 PM. View Actions Run.
No OpenAPI schema changes detected.
No GraphQL schema changes detected.
CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9021675054
/build_test
Workflow started at 5/9/2024, 2:34:49 PM. View Actions Run.
No OpenAPI schema changes detected.
No GraphQL schema changes detected.
CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9021889345
/build_test
Workflow started at 5/9/2024, 2:46:33 PM. View Actions Run.
No OpenAPI schema changes detected.
No GraphQL schema changes detected.
CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9022016975
/build_test
Workflow started at 5/15/2024, 6:30:54 PM. View Actions Run.
No GraphQL schema changes detected.
No OpenAPI schema changes detected.
CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9103521858
/build_test
Workflow started at 5/21/2024, 1:43:05 PM. View Actions Run.
CI build and push: At least one test failed ❌ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9179012039
Rebase after https://github.com/cryostatio/cryostat3/pull/449 is merged and that test failure will be fixed.
Rebase after #449 is merged and that test failure will be fixed.
Thnx @andrewazores This is very helpful. I wasn't sure what was causing the test failures!
/build_test
Workflow started at 5/21/2024, 2:09:39 PM. View Actions Run.
No OpenAPI schema changes detected.
No GraphQL schema changes detected.
CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9179352253
Looking good! I'd like to see a little refactoring to get rid of the static
methods next. You can add a method to Producers.java
to return a singleton instance of the URIUtil and inject that wherever it's needed, and I think you could even clean it up so that this is the only place where the new uri-range
String
property is injected, so that the Custom Discovery (or any other caller) only needs to supply the URL/URI to be tested and the range is already inferred from configuration.
/build_test
Workflow started at 5/27/2024, 1:51:03 PM. View Actions Run.
No GraphQL schema changes detected.
No OpenAPI schema changes detected.
CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9258630230
Refactoring suggestions: https://github.com/aali309/cryostat3/pull/21/files
/build_test
Workflow started at 5/29/2024, 1:31:02 PM. View Actions Run.
No GraphQL schema changes detected.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #323
Description of the change:
This change allows an environment variable to be configured so that...
Motivation for the change:
mentioned by: @andrewazores https://github.com/cryostatio/cryostat3/issues/323
How to manually test: