andrewazores commented 1 month ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #450

Implements the correct reports generation healthcheck behaviour, matching the previous 2.x versions.

This is useful for diagnosing reports sidecar configuration and is also used by some automated tests.

Check out and build PR
./smoketest.bash -O, then in another terminal http --auth=user:pass :8080/health. Check that reports are not configured but are available.
./smoketest.bash -Or, then in another terminal http --auth=user:pass :8080/health. Check that reports are both configured and available.
Edit compose/reports.yml and change the QUARKUS_REST_CLIENT_REPORTS_URL to a different port number or host name, then re-run ./smoketest.bash -Or. Now it should say that reports are configured but unavailable.

andrewazores commented 1 month ago

/build_test