cryostatio / cryostat

Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io
Other
11 stars 9 forks source link

fix(archive-on-stop): add missing @Transactional annotation on StopRecordingJob #454

Closed aali309 closed 4 months ago

aali309 commented 4 months ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #453

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

see https://github.com/cryostatio/cryostat3/issues/453

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. Go to Recordings
  3. Create a 10 second recording with Archive on Stop option selected and wait for 10 seconds
  4. See notification appears and table updated (recording is now in STOPPED state)
  5. Go to Recordings > Archived Recordings, the archived recording should be available
aali309 commented 4 months ago

/build_test

github-actions[bot] commented 4 months ago

Workflow started at 5/10/2024, 12:21:32 PM. View Actions Run.

github-actions[bot] commented 4 months ago

No GraphQL schema changes detected.

github-actions[bot] commented 4 months ago

No OpenAPI schema changes detected.

github-actions[bot] commented 4 months ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9035109072