cryostatio / cryostat

Other
7 stars 8 forks source link

fix(custom-targets): fix bug in transactions, handle more failure cases, include more helpful text with failure responses #488

Closed andrewazores closed 1 month ago

andrewazores commented 1 month ago

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #487 See also cryostatio/cryostat-web#1262

Description of the change:

How to manually test:

  1. Check out and build PR
  2. ./smoktest.bash -Otr
  3. Go to Custom Target creation form
  4. Try to create various custom targets like cryostat3:9091, localhost:0, sample-app-1:9093, jfr-datasource:11223, reports:11224
aali309 commented 1 month ago

/build_test

github-actions[bot] commented 1 month ago

Workflow started at 5/31/2024, 2:16:20 PM. View Actions Run.

github-actions[bot] commented 1 month ago

No GraphQL schema changes detected.

github-actions[bot] commented 1 month ago

No OpenAPI schema changes detected.

github-actions[bot] commented 1 month ago

CI build and push: All tests pass ✅ (JDK17) https://github.com/cryostatio/cryostat3/actions/runs/9322544977