cryostatio / cryostat

Other
7 stars 8 forks source link

[Bug] Adding stored credential does not update existing targets' JVM IDs #495

Closed andrewazores closed 3 weeks ago

andrewazores commented 4 weeks ago

Current Behavior

If a target application is discovered but is not initially connectable due to missing JMX credentials, then the target definition is retained but with a null/empty JVM ID. This appears in the Topology view as a target with the yellow warning exclamation mark. Adding a new Stored Credential that matches this target enables the Recording and Events views to work, but the Topology view continues to show the warning state.

Expected Behavior

After a matching Stored Credential is added, the Target should have its JVM ID set and the warning should disappear from the Topology view.

Steps To Reproduce

  1. ./smoktest.bash -t
  2. go to Topology and see that two of the es.andrewazor.demo targets are in a warning state
  3. add a stored credential: target.alias.contains('andrew'), admin:adminpass123
  4. check Events view and ensure templates and types can be listed
  5. check Topology view for warning state

Environment

No response

Anything else?

image

image

image