To recreate commits with GPG signaturegit fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #517
Description of the change:
Fixes up some issues that arose due to previous refactorings, where collections were improperly modified during traversal, or methods went from blocking operations to returning Unis which went ignored, or active recordings were improperly left running, or duplicate target definitions were not de-duplicated by JVM ID and thus were acted on multiple times.
How to manually test:
Check out and build PR
./smoketest.bash -Ot
Create an automated rule using the JSON below
Verify that targets have the active recording created and started
Verify that rule archives copies, then prunes extras later
Disable rule with clean option checked and ensure recordings are stopped
Re-enable rule and ensure recordings are restarted
{
"id": 1,
"name": "test",
"description": "",
"matchExpression": "target.connectUrl.startsWith('service') && target.jvmId != null",
"eventSpecifier": "template=Continuous,type=TARGET",
"archivalPeriodSeconds": 20,
"initialDelaySeconds": 0,
"preservedArchives": 2,
"maxAgeSeconds": 0,
"maxSizeBytes": 26214400,
"enabled": true
}
```<hr>This is an automatic backport of pull request #518 done by [Mergify](https://mergify.com).
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #517
Description of the change:
Fixes up some issues that arose due to previous refactorings, where collections were improperly modified during traversal, or methods went from blocking operations to returning
Uni
s which went ignored, or active recordings were improperly left running, or duplicate target definitions were not de-duplicated by JVM ID and thus were acted on multiple times.How to manually test:
./smoketest.bash -Ot
clean
option checked and ensure recordings are stopped