cryostatio / cryostat

Other
7 stars 8 forks source link

fix(recordings): uploaded archives should be viewable with Grafana #541

Closed tthvo closed 5 days ago

tthvo commented 5 days ago

Welcome to Cryostat! šŸ‘‹

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #540

Description of the change:

Consider connectUrl uploads as special case to use uploads as the jvmId.

Motivation for the change:

Uploaded archives can now be viewed with Grafana.

How to manually test:

  1. Built the cryostat container image or use CI snapshot image.
  2. Launch local smoketest with bash smoketest.bash -O.
  3. Upload any JFR file with the UI. The action should complete successfully and the archive should show up.
  4. Click on the far-right 3-dot and select View in Grafana.... This action should be work as expected.
tthvo commented 5 days ago

/build_test

github-actions[bot] commented 5 days ago

Workflow started at 6/28/2024, 3:17:27 AM. View Actions Run.

github-actions[bot] commented 5 days ago

No GraphQL schema changes detected.

github-actions[bot] commented 5 days ago

No OpenAPI schema changes detected.

github-actions[bot] commented 5 days ago

CI build and push: All tests pass āœ… (JDK17) https://github.com/cryostatio/cryostat/actions/runs/9708987588