cryostatio / cryostat

Other
7 stars 8 forks source link

fix(recordings): uploaded archives should be viewable with Grafana (backport #541) #542

Open mergify[bot] opened 5 days ago

mergify[bot] commented 5 days ago

Welcome to Cryostat! šŸ‘‹

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #540

Description of the change:

Consider connectUrl uploads as special case to use uploads as the jvmId.

Motivation for the change:

Uploaded archives can now be viewed with Grafana.

How to manually test:

  1. Built the cryostat container image or use CI snapshot image.
  2. Launch local smoketest with bash smoketest.bash -O.
  3. Upload any JFR file with the UI. The action should complete successfully and the archive should show up.
  4. Click on the far-right 3-dot and select View in Grafana.... This action should be work as expected.
    This is an automatic backport of pull request #541 done by Mergify.
andrewazores commented 5 days ago

This is too late to make it into 3.0.0, but it looks like we'll have a 3.0.1 fairly soon after. Will merge this for 3.0.1 once the 3.0.0 is finalized and released.

andrewazores commented 5 days ago

Whoops.