cryotools / cosipy

Coupled snowpack and ice surface energy and mass balance model in Python
GNU General Public License v3.0
52 stars 30 forks source link

New call to percolation subroutine produces negative liquid water content #34

Closed emilycollier closed 3 years ago

emilycollier commented 4 years ago

Water passed to scheme is negative when evaporation term dominates: Q = percolation(GRID, melt + evaporation + condensation + RAIN/1000.0 + lwc_from_melted_layers, dt)

emilycollier commented 3 years ago

Fixed in new release on master (COSIPY v1.4)