search

cryptag / leapchat

Ephemeral, encrypted, in-browser chat rooms
https://www.leapchat.org/
Other
184 stars 32 forks source link

Upgrade frontend #270

Closed elimisteve closed 1 year ago

elimisteve commented 1 year ago

@jimmcgaw Created this as a draft PR just so it's much harder to lose track of among the other branches

jimmcgaw commented 1 year ago

@jimmcgaw Created this as a draft PR just so it's much harder to lose track of among the other branches

Coolio. Removed the cruft and just left the frontend/ dir.

elimisteve commented 1 year ago

Looking great!

I do see this:

WARNING in ./src/components/chat/MentionSuggestions.js 27:100-115
export 'ViewingUserIcon' (imported as 'ViewingUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

WARNING in ./src/components/chat/MentionSuggestions.js 27:167-181
export 'OnlineUserIcon' (imported as 'OnlineUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

WARNING in ./src/components/chat/MentionSuggestions.js 27:224-239
export 'OfflineUserIcon' (imported as 'OfflineUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

Beyond that this looks pretty great to merge!

jimmcgaw commented 1 year ago

Looking great!

I do see this:

WARNING in ./src/components/chat/MentionSuggestions.js 27:100-115
export 'ViewingUserIcon' (imported as 'ViewingUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

WARNING in ./src/components/chat/MentionSuggestions.js 27:167-181
export 'OnlineUserIcon' (imported as 'OnlineUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

WARNING in ./src/components/chat/MentionSuggestions.js 27:224-239
export 'OfflineUserIcon' (imported as 'OfflineUserIcon') was not found in './UserStatusIcons' (possible exports: UserStatusIcon)
 @ ./src/components/chat/AutoSuggest.js 5:0-54 18:130-148
 @ ./src/components/chat/ChatContainer.js 20:0-40 53:74-85
 @ ./src/components/App.js 22:0-49 136:43-56
 @ ./src/index.js 15:0-35 31:36-39

Beyond that this looks pretty great to merge!

That's an existing problem. It's not caused by this branch. The new build is just superior in reporting issues like that. :)

I'm going to file an issue and fix the actual bug. Since it wasn't introduced here, I'd rather it didn't hold this back.

elimisteve commented 1 year ago

Merged! 🎉 Great job, @jimmcgaw 👌