search

cryptag / leapchat

Ephemeral, encrypted, in-browser chat rooms
https://www.leapchat.org/
Other
184 stars 32 forks source link

Message search #279

Closed jimmcgaw closed 1 year ago

jimmcgaw commented 1 year ago

message-seach

elimisteve commented 1 year ago

:fire: :fire: :fire:

elimisteve commented 1 year ago

  1. When an emoji is used in a message that was found via search, that emoji is bigger than it should be. Please constrain its size like the existing CSS does for messages.

  2. How about keeping the purple messages purple and the white ones white? I guess certain props aren't being passed to the messages in the search modal or something, so the ChatMessage objects in the modal all think they were sent by not-you?

  3. In the future it'd be cool to be able to put the app into Search Mode by clicking the search icon and filtering down the chat messages "in-line" -- that is, without needing the modal at all -- but that seems like a lot of work for not a huge benefit right now.

jimmcgaw commented 1 year ago
  • When an emoji is used in a message that was found via search, that emoji is bigger than it should be. Please constrain its size like the existing CSS does for messages.
  • How about keeping the purple messages purple and the white ones white? I guess certain props aren't being passed to the messages in the search modal or something, so the ChatMessage objects in the modal all think they were sent by not-you?
  • In the future it'd be cool to be able to put the app into Search Mode by clicking the search icon and filtering down the chat messages "in-line" -- that is, without needing the modal at all -- but that seems like a lot of work for not a huge benefit right now.

1 and 2 are super simple tweaks, of course. 3 makes me think you might have some more thought-out uses cases for search that haven’t been considered here. Let’s not merge until we chat next.

elimisteve commented 1 year ago

3 makes me think you might have some more thought-out uses cases for search that haven’t been considered here.

@jimmcgaw I hadn't thought much about search until now, but I just realized: with your modal approach it'll be easier to have universal search across not just messages, but tasks and todo lists, and eventually files... I think this is what Slack does, and it works well. So let's stick with the approach you took here :ok_hand: ; very nice.