Closed jimmcgaw closed 1 year ago
@jimmcgaw Rough UX thoughts; feel free to act on whichever parts you want, or hold off till we get user feedback, or have me to them, or suggest different solutions, or suggest things stay as they are:
Having the button where it is makes it easy to get to, but arguably it's more intuitive for it to be in the Settings modal.
Let's at least have equal horizontal spacing of the icons in this bar just above the textarea, including equal spacing between the left-most icon and the left edge of the bar, methinks.
Having the speaker jump right when muted feels a little off? Maybe force it to stay to the left so the spacing between icons remains constant? (If this is the only icon that changes its width when clicked then in the future maybe it should remain the right-most icon in the bar. Or maybe it's more weird for it to move as new features are added. Could put a vertical separator bar to its left to help solve that? Then the mute/enable audio button will always be to the right of the separator.)
@jimmcgaw Rough UX thoughts; feel free to act on whichever parts you want, or hold off till we get user feedback, or have me to them, or suggest different solutions, or suggest things stay as they are:
- Having the button where it is makes it easy to get to, but arguably it's more intuitive for it to be in the Settings modal.
This won't be the last time I rearrange the UI, including figuring out what goes in the Settings modal. My thoughts: if we need to show max progress at the end of these couple of weeks, let's leave it visible for now.
- Let's at least have equal horizontal spacing of the icons in this bar just above the textarea, including equal spacing between the left-most icon and the left edge of the bar, methinks.
I'll add some padding to the left of the emoji picker. Sound good?
- Having the speaker jump right when muted feels a little off? Maybe force it to stay to the left so the spacing between icons remains constant? (If this is the only icon that changes its width when clicked then in the future maybe it should remain the right-most icon in the bar. Or maybe it's more weird for it to move as new features are added. Could put a vertical separator bar to its left to help solve that? Then the mute/enable audio button will always be to the right of the separator.)
It doesn't actually change widths, the "off" icon is just narrower than the "on" one, so it seems to jump. If there were another icon to the right of the speaker, it wouldn't shift. For now, I think the visual is helpful because it clearly lets the user know something has changed.
In the long term: the most recent font-awesome icons version has many speakers, and the mute / unmute icon possibilities are much richer, and they wouldn't shift if changed. I'd like to get us to using those instead, so would rather not mess with this too much.
In generally, happy to discuss design or UX stuff more generally so I have a sense of how to make these decisions, instead of ad-hoc. Or if you have a style guide... :)
Sounds good! Pun intended... And nice work 🤠.
This PR introduces an option to mute the audio in the LeapChat browser window.
We haven't discussed audio design; perhaps this should be configurable in settings at a more granular level, ie "play sound for all new message", "play sound only when I am mentioned in a message", etc.) But at a minimum, the user should be able to turn it off.
What this PR does: