cryptee / web-client

Cryptee's web client source code for all platforms.
https://crypt.ee
Other
444 stars 22 forks source link

[Feature Request] the sort icon in folder view may show the sorting mode #109

Closed BasilTomato closed 3 years ago

BasilTomato commented 3 years ago

Is your feature request related to a problem? Please describe. It is a bit confusing that in the folder list the "sort items" icon remains the same independent of the sorting mode

Describe the solution you'd like The sort items icon shall reflect the current sorting mode, eg.:

Additional context n/a

johnozbay commented 3 years ago

Hey there!

Thanks a lot for filing this!

What happened here is that in V2 lots of people got confused about the button's states and what it shows. Basically, the question is :

Should the button's icon show the current sorting order? OR should it show the sort action you'll take once you press it?

For example, if you think about the delete button of a file, it has a trash icon, meaning that it shows the action you'll take if you press it.

But with sort, it's a bit weird, because you also want to know how your files are sorted right now. So if it shows : A - Z ↓

Does this mean what you're looking at right now is A-Z sorted ascending OR what you're looking at right now is actually A-Z descending ( AZ↑), and if you press the button it'll be AZ↓)

I hope this makes sense 😅

It's surprisingly difficult to design sort buttons apparently. So I'm now making it like the Photos sorter. It will have a popup, and show you how things are sorted right now, and all the other ways you can sort.

In the interest of pushing v3 out quicker, I made it a toggle switch, and very soon it will be a dropdown / pop-up much like the photos' sorter.

Hope this makes sense! Stay tuned, it should be ready in a week or so! ✌🏻

BasilTomato commented 3 years ago

"So I'm now making it like the Photos sorter. It will have a popup, and show you how things are sorted right now, and all the other ways you can sort." Thank you, this solution sounds great!

johnozbay commented 3 years ago

Here's how it's going to look like :

image

We're testing it on different OS / Browser / Device combinations, and will release soon 🎉

johnozbay commented 3 years ago

Give it a try and let me know what you think 🎉

BasilTomato commented 3 years ago

Thank you, it is great!

johnozbay commented 3 years ago

You're so very welcome 🎉