cryptee / web-client

Cryptee's web client source code for all platforms.
https://crypt.ee
Other
444 stars 22 forks source link

[Bug] Firefox Exported ECD uses JSON Extension #114

Closed jebbster88 closed 2 years ago

jebbster88 commented 3 years ago

As per comments in another issue. Downloading as ECD from firefox consistently results in a .json download, chrome however results in a .ecd

Will follow up with more info when I have it.


@jebbster88 It's super strange that your export resulted in a JSON format – that sounds like a whole separate bug right there.

ECD uses a json structure on the inside, but your file should have been something like file.ecd (Encrypted Cryptee Document) or file.uecd (Unencrypted Cryptee Document)

I wonder if this happens because your browser ignores the save-as name, (which ends with .ecd) and instead tries to sniff the filetype from the mime-type. ECD uses application/json – so this could be a strange separate bug. If possible could you please try this out and if you can reproduce what caused the filename issue file a separate issue for this ?

Originally posted by @johnozbay in https://github.com/cryptee/web-client/issues/102#issuecomment-792727965

jebbster88 commented 3 years ago

Almost certainly related to below. So most likely not a cryptee issue.

https://github.com/eligrey/FileSaver.js/issues/314 https://bugzilla.mozilla.org/show_bug.cgi?id=1684183

johnozbay commented 3 years ago

Wow! Amazing discovery! That's just next level weird.

I don't know why on earth Mozilla would casually decide to replace filenames / extensions of downloads 🤦🏻‍♂️ At least they seem to be on the right track now. https://hg.mozilla.org/integration/autoland/rev/181e16e12d9d

Thanks a lot for filing this here! Deeply appreciate it! We'll keep an eye out on this and try to solve this right away! (or at least find a temp workaround)

johnozbay commented 2 years ago

Some good news! Revisiting this – it seems to be fixed now. Closing 🎉 Many million thanks for spotting this bug, filing this issue, and digging up the root cause! Deeply appreciate the help! ✌🏻 Best, J