cryptee / web-client

Cryptee's web client source code for all platforms.
https://crypt.ee
Other
451 stars 23 forks source link

[Bug] Can't upload photos from Ipad (safari) after Cryptee update #216

Open MoralCoral opened 1 month ago

MoralCoral commented 1 month ago

Describe the bug Can't upload photos from Ipad (safari) after Cryptee update

To Reproduce Steps to reproduce the behavior:

  1. Enter Album
  2. Click upload
  3. Click "From photos"
  4. Select files
  5. Nothing happens

Alternative:

  1. Open Album
  2. Select files in Apples Photos app
  3. Drag the files from the Photos app to Cryptee
  4. Get the "Drop files here" promt from Cryptee
  5. Wait 15min but nothing happens

Expected behavior Photos will start uploading

System Information (please complete the following information):

Additional context This has worked before and stopped working after the Cryptee update

johnozbay commented 1 month ago

Hi there, thanks for reaching out with this. All our manual and automated tests seems to be working. (and we tested on the same exact device & OS version by the way) So chances are what you're dealing with is related to one of these :

— Lockdown Mode. If you have it enabled, please try again after disabling it. Here's why.

— iOS Safari privacy protections. Try "reduce privacy protections" them if Safari shows this banner. It seems to mess with browser's canvas, which affects thumbnail generation during uploads. (more info here)

— Failed app installation. There's always a non-zero chance that you had a network drop out or some unexpected issue during Cryptee's installation / last update. Try heading over to beta.crypt.ee, and uploading there. (currently both beta and live (crypt.ee) have the same exact version running. If your uploads work on beta.crypt.ee, then chances are you had an installation related issue, and we can look into what may have caused this, and offer guidance for you for a clean re-install. (as well as figure out what causes this and fix it on our end of course)

— Your photos. On iOS, there are a bunch of edge cases that could cause this. 1) iOS "Photos" app tries to convert all photos to JPG when uploading inside Safari. i.e. if you have a DNG or TIFF photo inside your photos app, Photos app pretty much grinds to a halt while trying to convert them (without any indication to the user), and after an absurd amount of time keeping the user waiting without any indication it will upload JPG). To combat this most professional photographers who shoot RAW photos use the Files app instead. Because if you select your photos using the Files app (by clicking on "Choose Files" instead of "Photo Library") then iOS doesn't try to convert the photos and you can upload RAW photos. It's absurd.

2) iOS and Safari have a pretty bad file manager, and it kinda fails miserably with large number of selections no matter how good the CPU on the iPad is. For example, open Files app, try copy pasting 1,000 photos from an SD card to another folder on your iPad. You'll notice the app will either crash or take forever without an indication. Same with selections in Safari. If you happen to be choosing lots of photos to upload to Cryptee, iOS may be grinding to a halt.

3) Available memory. If you're using lots of background apps etc + on battery saver in Safari, iOS reduces the available memory to all apps (incl Safari, and Safari reduces the available memory to all tabs, incl Cryptee) which can cause it to grind to a halt, depending on how many apps you have running.

4) Your specific photos themselves may be potentially buggy. Due to the fact that iOS tries to convert photos during upload, sometimes it messes up photos' metadata. So in order for us to eliminate this may be the problem, we would need to test with one of your photos. So if you'd like, and if it's okay for you to share, can you send one photo we can reproduce this issue with to support {at} crypt [dot] ee? That way we can make sure things are fixed.


We'll be looking forward to hearing from you to be able to assist you further. Best, J

MoralCoral commented 1 month ago

Hi, Thank you for the swift response. Ive gone through all of the above potential issues without avail. Even the beta channel test came out negative. I proceeded to save my photos from the Photos app to the files app and that worked. The issue I got then is that the heic "apples god forsaken file format" wont get converted to Jpeg during upload like it did if I used the Photos app. If i where to convert them myself I will loose the meta data so the photos would end up mixed or at the end of the album which is a bummer. The file types of the photos is a mix of Jpeg and Heic because some of them is from a friend who uses iPhone that had them airdropped to me. The crazy thing is that it worked about a week ago without any issues. Kind regards MoralCoral