cryptee / web-client

Cryptee's web client source code for all platforms.
https://crypt.ee
Other
444 stars 22 forks source link

[Bug] Issue typing in tables with Firefox Android #98

Open jebbster88 opened 3 years ago

jebbster88 commented 3 years ago

Describe the bug Unable to type within tables using Firefox Android, text appears in the wrong place.

To Reproduce Using firefox on android, create a table and try and type in it.

Expected behavior Text appears where you want it to.

Screenshots Table Demo

System Information (please complete the following information):

Additional context Issue present in both "PWA Mode" and "Normal Mode" on android. I wondered if it was swiftkey keyboard specifically causing the issue, but have confirmed the issue with all of the below.

Edit: Works fine in chrome for android

johnozbay commented 3 years ago

That is suuuuper odd!

Looking into what could be causing this right now, and we'll fix this up right away!

Thanks a million for sending this over the screengrab is especially helpful! ✌🏻

johnozbay commented 3 years ago

Hey! so good news and bad news.

Good news = it's not a Cryptee bug.

Bad news = Looks like this is a Firefox bug, and it's not just a Cryptee thing. Github / Reddit etc, pretty much anything that has a comment / text box has a text-selection / focus issue on Firefox Android. So try commenting on this thread in Firefox Android, and you'll notice you can't select the text.

@astarq was kind enough to file a bug report @ Mozilla / Firefox's github way back in Jun 6, 2020 : https://github.com/mozilla-mobile/fenix/issues/11301#issuecomment-632533669 [yay for Cryptee cameo btw] But looks like the bug hasn't been fixed yet.

And Cryptee's editor relies heavily on your cursor / selection's position and range to determine whether if you've selected a table (and typing in a table) or not. Otherwise we wouldn't be able to determine whether if you've selected the whole table, and want to type something to delete/replace the table entirely (or if you're just typing into the table cell)

So I'm afraid until this is fixed in Firefox, there really isn't much we can do about this. I'll try to reach out to our friends at Mozilla to see if we can convince them to get this fixed faster!

Hoping this makes sense!

We'll see if we can find a workaround in the meantime!

Best, J

jebbster88 commented 3 years ago

Haha should have known, FF on android definitely has its issues.

I'll stick with using chrome (but with cryptee as an installed "app"). I generally prefer FF for privacy reasons, but I doubt your Web app is doing much I'd want to block anyhow 😊

Thanks for looking into it

johnozbay commented 3 years ago

You're very welcome! thank you for these bug reports and all the help! Deeply appreciate it!

And yes – sadly Firefox has a couple of buzz-kill issues on Android... I wish they didn't. We really want to tell everyone to go use Firefox ... but yeah 😔

I'll keep this thread open to keep track and will ping it once it's fixed / out! Thanks again for everything and your patience!

tx71 commented 1 year ago

Unfortunately, a bot closed the bug on the Firefox side 😞

johnozbay commented 1 year ago

Hey there @tx71! IThe bot closed it despite my multiple ... hopeless ... attempts at trying to keep it open for 2 years now... Due to the fact that it's now considered platform work, they're tracking it under the bugzilla here : https://bugzilla.mozilla.org/show_bug.cgi?id=1365119

— 6 years later ... there's still no progress on this I'm afraid.  

Which makes me seriously worry for Firefox. I think the team is quite underfunded sadly...

I'll keep this issue open to keep track of things here... but sadly that's the best I can do at this point considering that FF has so many issues on Android nowadays that we can't in good conscience recommend it to anyone anymore...