crypti / cryptocurrencies

📋 Get a list of all the cryptocurrency symbols and names.
MIT License
260 stars 112 forks source link

Save Image Icons #6

Closed radiovisual closed 6 years ago

radiovisual commented 6 years ago

@brh55

This is my initial attempt to close #1, where the new build process saves the images for each icon to the /images directory after we get the updated currency list.

Its not a perfect solution, but it is a start. The images are named after the currency symbol, so technically, someone could use the symbol name to easily look up the image inside the images directory.

Check it out and let me know what you think.

The images are about 100 Mb as-is, so if we wanted to include images into the .json file, we could run the images through a scaling function that make 60x60 icons, or 24x24 icons, and saves a base64 encoding or shares a url, [and/]or, if we wanted to get crazy ambitious we could automate the building and mapping of a sprite sheet with a CSS and JSON file that has the coordinates necessary to navigate the sprite sheet.

This PR also enhances the terminal output with some useful information:

image

brh55 commented 6 years ago

Yes! This was definitely needed @radiovisual

I think a sprite would be the best next improvement that we could offer in a form of a css lib (with cdn, or locally stored).

For this library, we should do exactly as you proposed