Infinite names are accepted by the frontend

cryptic-game / frontend

The official frontend of Cryptic

https://play.cryptic-game.net

GNU Affero General Public License v3.0

11 stars 15 forks source link

Infinite names are accepted by the frontend #146

Closed ClientCrash closed 3 years ago

ClientCrash commented 4 years ago

Description

The frontend accepts infinite names (length). This causes a crash of the frontend and many requests could probably also influence the performance of the backend.

Reproduce

Put a very long String into the name field on sign-up

Expected behavior

The frontend only accepts names up to 256 characters.

System

OS: Windows
Browser: Chrome

JannikEmmerich commented 4 years ago

@MaxiHuHe04 See https://github.com/cryptic-game/java-backend-dev/pull/45 Now we have to add an error message in the frontend.