cryptimeleon / incentive-system

A cryptographic incentive system.
Apache License 2.0
3 stars 0 forks source link

Feature/vuerouter landing page #113

Closed this-kramer closed 2 years ago

this-kramer commented 2 years ago

Reason for this PR:

pschuermann97 commented 2 years ago

Wait a second: I thought we would reuse the vue-router that I have set up for the dsprotection service frontend?

this-kramer commented 2 years ago

Wait a second: I thought we would reuse the vue-router that I have set up for the dsprotection service frontend?

Well I basically ran npm install vue-router@4 and then copied your code :smiley:

pschuermann97 commented 2 years ago

Sounds suspicious, I better do a review ^^ Oh wait, actually it does: did you check the versioning? I used npm install vue-router@next

this-kramer commented 2 years ago

vue-router@next

It is the newest version, so we should be fine (https://router.vuejs.org/installation.html)

See package.json "vue-router": "^4.0.16" (dsprotection frontend uses "^4.0.13", so we should be fine)