search

cryptimeleon / mclwrap

A wrapper to bring the mcl pairing library into cryptimeleon
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Make mclwrap use its own package names and not Math's #21

Closed rheitjoh closed 3 years ago

rheitjoh commented 3 years ago

Mclwrap's bilinear group classes are currently found under org.cryptimeleon.math.structures.groups.elliptic.type3.mcl.

I would like to make Mclwrap not fake being part of Math like that anymore, for example using a directory structure such as org.cryptimeleon.mclwrap.bn254.

I just added standalone representation tests to mclwrap (didn't have those before) and they seem to collect all of Math's classes as well, due to passing org.cryptimeleon.math to StandaloneReprTest. Obviously Mclwrap is not going to include standalone repr tests for all those classes. That problem can be solved by giving Mclwrap its own packaging structure.

What do you think @JanBobolz ?

JanBobolz commented 3 years ago

Hard agree. The Java package names should be consistent with the gradle project names, i.e. org.cryptimeleon.mclwrap.stuff

Good catch!

rheitjoh commented 3 years ago

Fixed as part of #20