Deliver pre-compiled libmcljava.so

cryptimeleon / mclwrap

A wrapper to bring the mcl pairing library into cryptimeleon

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

Deliver pre-compiled libmcljava.so #25

Closed this-kramer closed 2 years ago

this-kramer commented 3 years ago

Currently, one has to manually install mcl. It would be easier to use, especially in a containerized context, if we could deliver a pre-compiled default version of mcl that is used if mcl is not installed.

rheitjoh commented 3 years ago

Good idea, I'll try and add some binaries.

rheitjoh commented 3 years ago

I added the precompiled .so file from my Linux on this branch in the lib folder. I am not sure about compatiblity with other systems, especially other Linux distros. Maybe you could test it on yours, @this-kramer ?

JanBobolz commented 3 years ago

To clarify: the whole issue would ask to:

Package .dll, .so files into the jar (by placing them in src/main/resources)
Configure the lib loading code to fall back to using the dll/so from the jar if the lib is not found on the system.

While we're at it, we might as well compile it for several platforms and package them all. Windows, Linux (x86, ARM), macOS (x86, M1). Ideally, we could get a script that does this automatically so that version bumps are easy to do.

JanBobolz commented 3 years ago

Also, quick note: please check mcl's license. If we want to ship the binary, we probably have to distribute their license alongside.

this-kramer commented 3 years ago

I added the precompiled .so file from my Linux on this branch in the lib folder. I am not sure about compatiblity with other systems, especially other Linux distros. Maybe you could test it on yours, @this-kramer ?

Works on my machine (Ubuntu 20.04)

JanBobolz commented 2 years ago

This is fixed by #33