search

cryptlex / lexactivator-js

LexActivator API wrapper for Node.js (licensing library)
https://cryptlex.com
MIT License
15 stars 5 forks source link

[feat] Typescript support #32

Closed robertsLando closed 1 year ago

robertsLando commented 2 years ago

Could you add some types please?

robertsLando commented 1 year ago

any news on this?

@ahmad-kemsan

adnan-kamili commented 1 year ago

@azan-n Please add the typings

adnan-kamili commented 1 year ago

@robertsLando done

robertsLando commented 1 year ago

Thanks! 🙏🏼

robertsLando commented 1 year ago

@adnan-kamili This specific commit: https://github.com/cryptlex/lexactivator-js/commit/2085835e8518fecd42dcf24a054d8121c31a74cd#diff-45e96039b1f6b3afb46b650541cf676aad1ec7954302df30806f6266ae19fa6cL7

Broke my server error handling logic as now code doesn't exist as property anymore. Would it be possible to restore it please?

cc @azan-n @ahmad-kemsan

azan-n commented 1 year ago

@adnan-kamili This specific commit: 2085835#diff-45e96039b1f6b3afb46b650541cf676aad1ec7954302df30806f6266ae19fa6cL7

Broke my server error handling logic as now code doesn't exist as property anymore. Would it be possible to restore it please?

cc @azan-n @ahmad-kemsan

I apologize for this mistake. I'll push a quick fix just now.

adnan-kamili commented 1 year ago

@robertsLando Please update to the latest version, the issue is fixed now.

robertsLando commented 1 year ago

Thanks for the quick fix 🙏🏼