crypto-chassis / ccapi

A header-only C++ library for interacting with crypto exchanges. Bindings for Python, Java, C#, Go, and Javascript are provided.
https://discord.gg/b5EKcp9s8T
MIT License
582 stars 201 forks source link

no correlation Id returned by event notifying orderbook subscription with Gate.io #422

Closed nelyajizi closed 1 year ago

nelyajizi commented 1 year ago

Describe the bug when subscribing to orderbook channel of Gate.io, the correlation id given is not retrieved in the subscription started associated event.

To Reproduce Steps to reproduce the behavior: std::vector subscriptions; subscriptions.emplace_back(CCAPI_EXCHANGE_NAME_GATEIO, "ETH_USDT", CCAPI_MARKET_DEPTH, "MARKET_DEPTH_MAX=5", my_id);
marketDataSession->subscribe(subscriptions); see in handler's processEvent, the event when message type is ccapi::Message::Type::SUBSCRIPTION_STARTED const auto &cid{message.getCorrelationIdList()}; cid is empty

Expected behavior the same behavior than if we don't use "MARKET_DEPTH_MAX=5" and though use the ticker channel instead. i don't find this issue on other exchanges as Kucoin for example.

Screenshots image

Additional context I am using 5.45.5 version

cryptochassis commented 1 year ago

https://github.com/crypto-chassis/ccapi/pull/424 @nelyajizi Fixed and released.

nelyajizi commented 1 year ago

thx @cryptochassis