search

crypto-code / pe

0 stars 0 forks source link

No Date Validation #3

Open crypto-code opened 2 years ago

crypto-code commented 2 years ago

I am able to give assignments with due dates that are before today's date.

image.png

nus-pe-bot commented 2 years ago

Team's Response

This is a valid concern raised. However, we have stated in our UserGuide the following under the Tips section in Give:

"You can give assignments with due dates before today in case you wish to keep a record of old assignments."

In addition, the ability to add past dates does not hinder the user's ability to fully utilize our application, also considering the fact that all of these assignments will be flushed to the bottom. The intention behind this feature was intended and thus we feel the need to not accept this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As this app is designed for TAs to manage their students for a semester, does it make sense to add assignments that aren't in the semester or remotely in the year. And this is the case even for future assignments. A TA my by mistake add assignments thousands of years in the past and thousands of years in the future, and the app doesn't put any check on it and hence can mess up the assignment list of a student.

Adding Past Assignment:

image.png

Adding Future Assignment:

image.png

the ability to add past dates does not hinder the user's ability to fully utilize our application, also considering the fact that all of these assignments will be flushed to the bottom

This does not seem to be the case, the order is from oldest assignment to the newest, as shown below.

image.png

Although allowing for past dates is a feature of the app, it had an unforeseen side effect of being able to add any date and this could mess up the list especially since it is ordered from oldest to newest.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I agree that the severity on this issue on its own is low, but when combined with the way that the assignments are ordered in the list makes the severity medium, as it causes inconvenience to any TA who has a long list of assignments to sort through and the older ones will be shown first, including the ones with extreme dates.