search

crypto-com / defi-wallet-core-rs

Cross-platform, cross-blockchain wallet library in Rust for DeFi Wallet and other applications.
Other
47 stars 16 forks source link

Problem: unnecessary use of REST API instead of grpc-web #511

Open tomtau opened 2 years ago

tomtau commented 2 years ago

https://github.com/crypto-com/defi-wallet-core-rs/blob/main/common/src/node/cosmos_sdk.rs#L261 some of the Cosmos SDK client functions use REST API -- the reason for it was that cosmos-sdk-proto had the default generation of proto definitions which doesn't work with grpc-web. This seems to be feature-guarded now by grpc-transport: https://github.com/cosmos/cosmos-rust/blob/main/cosmos-sdk-proto/src/prost/cosmos-sdk/cosmos.bank.v1beta1.rs#L125 so it should be possible to use grpc-web. Perhaps the CosmosSDKClient and nft's Client can be unified?

stevenatcrypto commented 2 years ago

I am sorry that I am a little busy in this week. Will start to work on this issue on next week.

stevenatcrypto commented 2 years ago

Working on this issue.