search

crypto-com / defi-wallet-core-rs

Cross-platform, cross-blockchain wallet library in Rust for DeFi Wallet and other applications.
Other
48 stars 16 forks source link

Problem: missing ifdef for __ANDROID__ (fix #839) #840

Closed leejw51crypto closed 1 year ago

leejw51crypto commented 1 year ago

Solution: add ifdef for android

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a19ff86) 43.10% compared to head (d5275e2) 43.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #840 +/- ## ======================================= Coverage 43.10% 43.10% ======================================= Files 48 48 Lines 9136 9136 ======================================= Hits 3938 3938 Misses 5198 5198 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tomtau commented 1 year ago

The nix actions seems to have some issues:

Action failed with error: Error: Unable to locate executable file: cachix. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

leejw51crypto commented 1 year ago

The nix actions seems to have some issues:

Action failed with error: Error: Unable to locate executable file: cachix. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

yes, looking into nix issues

tomtau commented 1 year ago

the nix issue should hopefully be fixed in this PR: https://github.com/crypto-com/defi-wallet-core-rs/pull/841