crypto-com / defi-wallet-core-rs

Cross-platform, cross-blockchain wallet library in Rust for DeFi Wallet and other applications.
Other
48 stars 16 forks source link

Problem: ContractApproval and ContractTransfer do not implement Serialize and Deserialize (fix #908) #909

Closed damoncro closed 1 year ago

damoncro commented 1 year ago

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (7021c5d) 43.10% compared to head (2baab69) 43.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #909 +/- ## ========================================== - Coverage 43.10% 43.09% -0.01% ========================================== Files 48 48 Lines 9139 9141 +2 ========================================== Hits 3939 3939 - Misses 5200 5202 +2 ``` | [Impacted Files](https://codecov.io/gh/crypto-com/defi-wallet-core-rs/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com) | Coverage ฮ” | | |---|---|---| | [common/src/node/ethereum/utils.rs](https://codecov.io/gh/crypto-com/defi-wallet-core-rs/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com#diff-Y29tbW9uL3NyYy9ub2RlL2V0aGVyZXVtL3V0aWxzLnJz) | `0.00% <0.00%> (รธ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-com)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.