refactor(message): derive Debug

crypto-crawler / crypto-crawler-rs

A rock-solid cryptocurrency crawler library.

Apache License 2.0

227 stars 73 forks source link

Closed pan93412 closed 2 years ago

pan93412 commented 2 years ago

We implemented these:

soulmachine commented 2 years ago

Please keep Debug only
Please remove Copy and Clone. Otherwise users can copy messages automatically, which results in inefficient code. Ideally a message should be movable but not clonable, thus it can only be processed one time.
Please remove Eq and PartialEq from crypto-message/src/lib.rs, I removed them specifically in https://github.com/crypto-crawler/crypto-crawler-rs/commit/3cb015034b7882175cdf8bb3bd1d5d075daa2239

pan93412 commented 2 years ago

@soulmachine request for review. thanks a lot!

soulmachine commented 2 years ago

@soulmachine request for review. thanks a lot!

Please also remove Clone, if you code copies messages, you need to refactor your business logic to make sure every message is consumed once

pan93412 commented 2 years ago

r? @soulmachine