search

crypto-crawler / crypto-crawler-rs

A rock-solid cryptocurrency crawler library.
Apache License 2.0
227 stars 73 forks source link

tests(rest-client/zbg): don't fail on unreachable #49

Closed pan93412 closed 2 years ago

pan93412 commented 2 years ago
soulmachine commented 2 years ago

If you get a network error, you should try to fix your network, for example restart your router, use a HTTP proxy, etc.

We should fail fast and fail explicitly in tests, not hide errors.

pan93412 commented 2 years ago

If you get a network error, you should try to fix your network, for example restart your router, use a HTTP proxy, etc.

We should fail fast and fail explicitly in tests.

Actually this fail is happened in CI: https://github.com/crypto-crawler/crypto-crawler-rs/runs/7625266397

The environment of GitHub Actions is unstable, and I think we can accept some errors.