Implemented `parse_candlestick()` for Bybit

crypto-crawler / crypto-crawler-rs

A rock-solid cryptocurrency crawler library.

Apache License 2.0

227 stars 73 forks source link

Implemented `parse_candlestick()` for Bybit #50

Closed suhrm closed 2 years ago

suhrm commented 2 years ago

Hi really cool collection of crates, I have added parsing of bybits candlesticks as this was missing and is my exchange of choice.

There are some fields I am unsure about such as the period formatting and the quote_volume

Please let me know if anything needs to be changed or added. Regards.

soulmachine commented 2 years ago

Hi @suhrm , thanks for you work! Your code does have some issues, I tried to commit to this PR but it seems I don't have permission to commit to your repo.

Anyway, I"ll merge your PR first and commit my changes to the main branch. You can check src/exchanges/bybit.rs and tests/bybit.rs and you'll see what I've changed.

suhrm commented 2 years ago

No problem, I do not have that much experience with pull-request to public repos, as I have mostly done corporate stuff previously. Thanks for the feedback will make sure to enable editing in the future if I find something else to add :)