search

crypto-org-chain / chain-jslib

Other
32 stars 16 forks source link

Problem: Add amino support for MsgDeposit & MsgSubmitProposal #377

Closed crypto-matto closed 2 years ago

crypto-matto commented 2 years ago

I'm seeing that in all other toRawAminoMsg() function, at the end of the return, they're putting as legacyAmino.MsgXXX. Is it V2 shall remove this?

codecov[bot] commented 2 years ago

Codecov Report

Merging #377 (8eaa391) into dev (e9cdc5c) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #377      +/-   ##
==========================================
+ Coverage   97.97%   98.00%   +0.03%     
==========================================
  Files         159      159              
  Lines        7509     7525      +16     
  Branches      571      571              
==========================================
+ Hits         7357     7375      +18     
+ Misses        152      150       -2
Impacted Files Coverage Δ
...b/src/transaction/msg/v2/gov/v2.MsgDeposit.spec.ts 100.00% <100.00%> (ø)
lib/src/transaction/msg/v2/gov/v2.MsgDeposit.ts 97.36% <100.00%> (+2.92%) :arrow_up:
...ransaction/msg/v2/gov/v2.MsgSubmitProposal.spec.ts 100.00% <100.00%> (ø)
...src/transaction/msg/v2/gov/v2.MsgSubmitProposal.ts 94.44% <100.00%> (+3.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9cdc5c...8eaa391. Read the comment docs.