crypto-org-chain / chain-main

Cronos POS Chain⛓: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
497 stars 352 forks source link

Problem: update voting_period is not tested #1017

Closed mmsqe closed 2 months ago

mmsqe commented 1 year ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.34%. Comparing base (c26a336) to head (2d7d581). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1017 +/- ## ======================================= Coverage 34.34% 34.34% ======================================= Files 93 93 Lines 14105 14105 ======================================= Hits 4844 4844 Misses 8319 8319 Partials 942 942 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `25.79% <ø> (ø)` | | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.27% <ø> (ø)` | | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `27.52% <ø> (ø)` | | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.53% <ø> (ø)` | | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.53% <ø> (ø)` | | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.32% <ø> (ø)` | | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.