crypto-org-chain / chain-main

Cronos POS Chainโ›“: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
497 stars 352 forks source link

Problem: missing validation on nft-transfer message fields #1019

Closed yihuang closed 11 months ago

yihuang commented 11 months ago

Solution:

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 11 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d71c53c) 33.05% compared to head (e5369f8) 33.08%.

Files Patch % Lines
app/ante.go 66.66% 6 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1019 +/- ## ========================================== + Coverage 33.05% 33.08% +0.03% ========================================== Files 126 126 Lines 20014 20041 +27 ========================================== + Hits 6616 6631 +15 - Misses 12339 12349 +10 - Partials 1059 1061 +2 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage ฮ” | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `20.71% <51.85%> (+0.02%)` | :arrow_up: | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.66% <29.62%> (+0.01%)` | :arrow_up: | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.03% <51.85%> (+0.05%)` | :arrow_up: | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.01% <51.85%> (+0.05%)` | :arrow_up: | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `24.81% <66.66%> (+0.04%)` | :arrow_up: | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <51.85%> (+0.05%)` | :arrow_up: | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <51.85%> (+0.05%)` | :arrow_up: | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.69% <51.85%> (+0.05%)` | :arrow_up: | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.01% <51.85%> (+0.05%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.99% <11.11%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.