crypto-org-chain / chain-main

Cronos POS Chain⛓: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
496 stars 352 forks source link

Problem: Crypto.org Chain is renamed to Cronos POS Chain #1029

Closed calvinaco closed 1 month ago

calvinaco commented 7 months ago

Solution: Rename all occurrences to updated values

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b2d5ed7) 33.10% compared to head (15de945) 33.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1029 +/- ## ========================================== - Coverage 33.10% 33.08% -0.02% ========================================== Files 126 126 Lines 20041 20041 ========================================== - Hits 6634 6631 -3 - Misses 12345 12349 +4 + Partials 1062 1061 -1 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `20.71% <100.00%> (ø)` | | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.66% <100.00%> (ø)` | | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.03% <100.00%> (ø)` | | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.01% <100.00%> (ø)` | | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `24.81% <100.00%> (-0.02%)` | :arrow_down: | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <100.00%> (ø)` | | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <100.00%> (ø)` | | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.69% <100.00%> (ø)` | | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.01% <100.00%> (ø)` | | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1029/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.99% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomas-nguy commented 7 months ago

is it still a draft ? @calvinaco

infinitebreakfast commented 6 months ago

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

yihuang commented 6 months ago

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

hi, how can we help you? which application do you mean?

infinitebreakfast commented 6 months ago

Salutations and hello. Back in 2022, many changes to the cdc.app as a result of either hacking or change in policy caused an error in a transaction that absolutely SHOULD have never happened. I had transacted in various crypto. Mostly xlm, but never making the mistake of sending coins via the wrong network. I digress, as i stated I had previously transacted in USDC and on this particular day, after an update to the platform. ERC-20 was no longer the DEFAULT setting for sending USDC. Instead CRONOS network was the default setting. I sent a transfer of 500 usdc via cronos. It still sits here to this day and im positive that it can be recovered before waiting for CRO to be offered at kraken exchange.

Below is the adresss.

If nothing else. Explain to me how 5 other tokens have managed to find their way to this address on the cronos network. I understand the concept of TVL. But this was a very expensive lesson that could have been avoided. I have been waiting for a response from CDC for issues as benign as referral bonuses for over 2 weeks. There has never been an intelligent explanation furnished from CDC as to why this happened. Makes me laugh, given that story where by they sent 25 million dollars in eth to the wrong address. Yet somehow they were able to reverse this transaction.

I understand the concept (to a degree) of custodial wallets. Kraken at this time does not offer a custodial wallet, still has always rubbed me the wrong way that it was not soley user error. There never should have even been the option to send an ERC -20 token via CRONOs. Like i stated i had transacted not only in USDC but several other currencies and never had an issue until several changes at the time on CDC platform with respect to UI layout, and Whitelisted addresses.

Thank you for coming to my ted talk.

If nothing else i hope to understand how the additional tokens came to find themselves parked in the same location as my 500.20 usdc.

0xaF54ce06bc1384158b016B2E33cc3A452D1862fd

infinitebreakfast commented 6 months ago

B08F0F8A-945E-46DE-ACD3-E1A55E077B84 6C9DCF43-62A2-46A3-A8F7-919BCB01237E

I have proof. Of the changes they made to the ui.

infinitebreakfast commented 6 months ago

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

hi, how can we help you? which application do you mean?

Crypto.com app crypto.com defi. Takes 1 min or less to receive xlm more than 45 to send. I would definitely love to understand what the cronos network adds to utility. Should try the exchange just to short in volatility but lol kraken pro exists. Coinbase pro exist. The only way this company moves up in the food chain is by way of other companies disappearing entirely. Idk how cdc or cro ever gets compared to bnb. Market cap and volume are real things!

yihuang commented 1 month ago

fixed by: https://github.com/crypto-org-chain/chain-main/pull/1071