yihuang commented 6 months ago

Solution:

use go 1.22
update nixpkgs to nixpkgs-unstable
rustc to 1.75
update python dependencies in integration tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

socket-security[bot] commented 6 months ago

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

codecov[bot] commented 6 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c0436a5) 30.08% compared to head (4f2481e) 32.92%.

Files	Patch %	Lines
app/test_helpers.go	0.00%	7 Missing :warning:
x/nft/simulation/operations.go	0.00%	7 Missing :warning:
x/chainmain/client/cli/testnet.go	50.00%	2 Missing :warning:
cmd/chain-maind/app/app.go	75.00%	1 Missing :warning:
x/icaauth/types/params.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1034 +/- ## ========================================== + Coverage 30.08% 32.92% +2.84% ========================================== Files 125 131 +6 Lines 20039 20164 +125 ========================================== + Hits 6028 6640 +612 + Misses 12965 12461 -504 - Partials 1046 1063 +17 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `20.61% <71.42%> (-0.10%)` | :arrow_down: | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.55% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.92% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `24.71% <71.42%> (-0.10%)` | :arrow_down: | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.79% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.79% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.58% <58.73%> (-0.11%)` | :arrow_down: | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.90% <58.73%> (-0.11%)` | :arrow_down: | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.60% <58.92%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmsqe commented 6 months ago

do we need bump chainlibpy as well?

yihuang commented 6 months ago

do we need bump chainlibpy as well?

it seems easier to refactor the test case itself.

crypto-org-chain / chain-main

Problem: nixpkgs and python dependencies are out of date #1034

PR Checklist:

Codecov Report