crypto-org-chain / chain-main

Cronos POS Chainโ›“: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
496 stars 352 forks source link

Problem: slashing fix is not included #1036

Closed yihuang closed 6 months ago

yihuang commented 6 months ago

Solution:

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 33.08%. Comparing base (641d3b9) to head (54a21ba).

:exclamation: Current head 54a21ba differs from pull request most recent head ead1ae4. Consider uploading reports for the commit ead1ae4 to get more accurate results

Files Patch % Lines
app/forks.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v4 #1036 +/- ## ============================================== + Coverage 30.08% 33.08% +3.00% ============================================== Files 125 127 +2 Lines 20039 20043 +4 ============================================== + Hits 6028 6631 +603 + Misses 12965 12351 -614 - Partials 1046 1061 +15 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage ฮ” | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `20.71% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.66% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.02% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.00% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `24.80% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.89% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.89% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `9.69% <33.33%> (-0.01%)` | :arrow_down: | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.00% <33.33%> (-0.01%)` | :arrow_down: | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `10.99% <33.33%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.