crypto-org-chain / chain-main

Cronos POS Chain⛓: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
496 stars 352 forks source link

Problem: no minimum packet timeout check for send-tx to host chain on behalf of ica account #1070

Open mmsqe opened 1 month ago

mmsqe commented 1 month ago

we need a minimum value for the relative timeout of send-tx in ica controller after migrate to ibc 8.3.x and remove icaauth module in https://github.com/crypto-org-chain/chain-main/pull/1068.

yihuang commented 1 month ago

the timeout is set by user right? what is the consequence of too low?

mmsqe commented 1 month ago

yes, but msg server still ensure this min timeout is appropriate before.

yihuang commented 1 month ago

yes, but msg server still ensure this min timeout is appropriate before.

I mean why do we need it, what's the consequence without it.

mmsqe commented 1 month ago

I guess low timeout make it easier to trigger close for ordered channel, but I'm not sure about the history reason.