crypto-org-chain / chain-main

Cronos POS Chain⛓: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
498 stars 353 forks source link

Problem: minor security issue in github workflow #1072

Closed yihuang closed 4 months ago

yihuang commented 4 months ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

yihuang commented 4 months ago

/runsim

github-actions[bot] commented 4 months ago

Simulation tests started and triggered by /runsim. Will update here when it succeeds or fails. Can further check progress here

yihuang commented 4 months ago

/runsim

github-actions[bot] commented 4 months ago

Simulation tests started and triggered by /runsim. Will update here when it succeeds or fails. Can further check progress here

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.34%. Comparing base (1baff8a) to head (4714f67).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1072 +/- ## ========================================== - Coverage 36.55% 34.34% -2.21% ========================================== Files 101 93 -8 Lines 14350 14105 -245 ========================================== - Hits 5245 4844 -401 - Misses 8158 8319 +161 + Partials 947 942 -5 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `25.79% <ø> (ø)` | | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.27% <ø> (ø)` | | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `27.52% <ø> (ø)` | | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.53% <ø> (ø)` | | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.53% <ø> (ø)` | | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.32% <ø> (ø)` | | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.54% <ø> (ø)` | | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

/runsim simulation test has succeeded 🎉 Can further check here

github-actions[bot] commented 4 months ago

/runsim simulation test has succeeded 🎉 Can further check here